[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r17625 - trunk/subversion/libsvn_fs_base

From: Max Bowsher <maxb1_at_ukf.net>
Date: 2005-12-05 01:47:42 CET

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Garrett Rooney wrote:
> On 12/4/05, mbk@tigris.org <mbk@tigris.org> wrote:
>
>
>>+static svn_error_t *
>>+unknown_node_kind (const char *rep_key)
>>+{
>>+ return svn_error_createf
>>+ (SVN_ERR_FS_CORRUPT, NULL,
>>+ _("Unknown node kind for representation '%s'"), rep_key);
>>+}
>
>
> Speaking as someone who's spent a lot of time in libsvn_ra_dav lately,
> I'm getting more and more unthrilled about these sort of wrapper
> functions for generating errors. They make the file and line info in
> maintainer mode builds essentially useless, and if we could avoid them
> going forward I'm sure that the future developers who have to debug
> this code would appreciate it.

If we converted these error factory functions into macros, we would get
correct file/line info, but retain the shorthand convenience.

Max.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Cygwin)

iD8DBQFDk44ufFNSmcDyxYARAnfrAJ40ShAzygvzwT1WRtp22ToXLxDeFQCeIcN9
Op9xqtxYjZuQLOjoo9EvLPs=
=sZDL
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Dec 5 01:48:23 2005

This is an archived mail posted to the Subversion Dev mailing list.