[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Fixed length character buffers?

From: John Peacock <jpeacock_at_rowman.com>
Date: 2005-12-04 02:52:24 CET

Peter N. Lundblad wrote:
> I added a file with an URL that's longer than 255 characters. It was just
> truncated, so we have a problem for people with very long paths...

Problem in the sense that $URL$ was not the entire file path, not in the sense
that it took over their machine and started sending cyborgs back in time. ;-)

> I'm not completely sure what happens with the translation routines fi we
> just lift this limit, though.

SVN_KEYWORD_MAX_LEN predates the keywords-as-hash code. There shouldn't be any
reason that it has to stay that way; AFAICT, this was just a "we'll never need
to exceed this for a single line" assumption (and we know what that leads to ;).

Since I know the keywords code better than most, I'll try and take a walk down
memory lane and see if there is any reason why we cannot drop the fixed length
limit. If Erik wants to rewrite this code to use stringbufs instead, more power
to him...


John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4720 Boston Way
Lanham, MD 20706
301-459-3366 x.5010
fax 301-429-5747
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Dec 4 02:52:59 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.