[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r17613 - trunk/subversion/libsvn_wc

From: mark benedetto king <mbk_at_lowlatency.com>
Date: 2005-12-04 00:27:24 CET

On Sat, Dec 03, 2005 at 06:05:59PM -0500, David James wrote:
> On 12/3/05, Max Bowsher <maxb1@ukf.net> wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > Peter N. Lundblad wrote:
> > > On Sat, 3 Dec 2005 maxb@tigris.org wrote:
> > >
> > >>Author: maxb
> > >>Date: Sat Dec 3 12:00:15 2005
> > >>New Revision: 17613
> > >>
> > >>Modified:
> > >> trunk/subversion/libsvn_wc/props.c
> > >>
> > >>Log:
> > >>* subversion/libsvn_wc/props.c (svn_wc__load_props): Silence warning.
> > >
> > > Erik H??lsmann pointed out this warning on wc-propcaching some time ago. A
> > > discussion followed where I pointed out that GCC 4 adds a lot of these
> > > warnings when you pass an uninitialized variable to a function as an "out"
> > > parameter; it can't know that the function will set the variable before
> > > using it. So, this warning is pretty useless when using GCC 4. I'm not
> > > sure if we should continue to silence such warnings.
> >
> > Then should we document that the official way build Subversion is with
> > - -Wno-undefined?
> +1
>

It's either that or contribute a patch to GCC that adds a function
attribute that tells the compiler what to do.

--ben

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Dec 4 00:24:40 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.