[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r17613 - trunk/subversion/libsvn_wc

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-12-04 00:01:17 CET

On Sat, 3 Dec 2005, Max Bowsher wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Peter N. Lundblad wrote:
> > On Sat, 3 Dec 2005 maxb@tigris.org wrote:
> >
> >>Author: maxb
> >>Date: Sat Dec 3 12:00:15 2005
> >>New Revision: 17613
> >>
> >>Modified:
> >> trunk/subversion/libsvn_wc/props.c
> >>
> >>Log:
> >>* subversion/libsvn_wc/props.c (svn_wc__load_props): Silence warning.
> >
> > Erik Húlsmann pointed out this warning on wc-propcaching some time ago. A
> > discussion followed where I pointed out that GCC 4 adds a lot of these
> > warnings when you pass an uninitialized variable to a function as an "out"
> > parameter; it can't know that the function will set the variable before
> > using it. So, this warning is pretty useless when using GCC 4. I'm not
> > sure if we should continue to silence such warnings.
>
> Then should we document that the official way build Subversion is with
> - -Wno-undefined?
>
Seems right to me, or change our coding style to always initialize things,
but I don't like that.

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Dec 4 00:02:09 2005

This is an archived mail posted to the Subversion Dev mailing list.