Re: Patch: www/faq.html

On Sat, Dec 03, 2005 at 11:30:15AM -0500, Greg Hudson wrote:
> On Sat, 2005-12-03 at 10:05 -0500, Dan Cross wrote:
> > + execl("/usr/local/bin/svn", "svn", "update", "/home/joe/public_html/", NULL);
>
> This is reeeeally really nitpicky, but since execl() is a
> variable-arguments function, the NULL at the end is not automatically
> casted to the correct type. So the final NULL should be "(const char *)
> NULL" to ensure that it is passed correctly.
>

Committed (with Greg's tweak) in r17612.

Thanks for the patch!

--ben

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Dec 3 17:49:23 2005