[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Fixed length character buffers?

From: <kfogel_at_collab.net>
Date: 2005-12-03 00:20:04 CET

Garrett Rooney <rooneg@electricjellyfish.net> writes:
> On 02 Dec 2005 17:05:38 -0600, kfogel@collab.net <kfogel@collab.net> wrote:
>
> > ...oh, wait: under some circumstances, that length has to include both
> > the keyword and its value. For example, see the strncmp() that
> > appears early in libsvn_subr/subst.c:translate_keyword_subst().
> >
> > Do we have a problem right now? Have we just been lucky that no one's
> > had, say, a really long URL as the value of the $URL$ keyword?
>
> No, we haven't been lucky, someone submitted a bug report about that a
> while back, there was a buffer overflow in that case.

And r17149 appears to have fixed it (thanks, Philip). I'm going over
that rev now, and doing some other explorations, just to make sure.

-Karl

-- 
www.collab.net  <>  CollabNet  |  Distributed Development On Demand
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Dec 3 01:44:10 2005

This is an archived mail posted to the Subversion Dev mailing list.