[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Fixed length character buffers?

From: Erik Huelsmann <ehuels_at_gmail.com>
Date: 2005-11-30 20:57:02 CET

> + char keyword_buf[SVN_KEYWORD_MAX_LEN];
> + apr_size_t keyword_off;
> + char src_format[2];

The segment above is from my last commit creating the eol-recoding stream.

Here, and some other places in our code, we still use fixed length
character buffers. I understand the case where we use them for MD5
sums: APR expects us to.

In the above case, nobody *wants* us to use a fixed character buffer.
Using stringbufs, the above character limit (SVN_KEYWORD_MAX_LEN) can
easily be lifted, if we want to.

Also, I consider it not very future proof to build a 1.3 client with
that constant: if later clients have a higher value for that
constant...

bye,

Erik.
Received on Wed Nov 30 21:10:00 2005

This is an archived mail posted to the Subversion Dev mailing list.