[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r17559 - in trunk/subversion: libsvn_subr

From: Erik Huelsmann <ehuels_at_gmail.com>
Date: 2005-11-30 20:24:33 CET

> > + /* Setup the baton fields */
> > + baton->stream = stream;
> > + baton->in_baton
> > + = create_translation_baton (eol_str, repair, keywords, expand, pool);
> > + baton->out_baton
> > + = create_translation_baton (eol_str, repair, keywords, expand, pool);
> > + baton->written = FALSE;
> > + baton->readbuf = svn_stringbuf_create ("", pool);
>
> > + baton->readbuf_off = 0;
> > + baton->buf = apr_palloc (pool, SVN_STREAM_CHUNK_SIZE + 1);
> > + baton->pool = svn_pool_create (pool);
> > +
> The above may leave 256K of buffers allocated in pool after using this
> stream.

Why 256K? I would expect it to be a multiple of the size of
SVN_STREAM_CHUNK_SIZE (which is 10kB)! So, as you see, I don't see any
reason to go from 10K to the 8K you suggest below...

bye,

Erik.
Received on Wed Nov 30 20:40:01 2005

This is an archived mail posted to the Subversion Dev mailing list.