Re: [PATCH] INSTALL file to explain neon installation more lucidly

Madan U S <madan@collab.net> writes:
> After sometime, I tried doing the subversion build based on the
> INSTALL file and found that the instructions about the NEON
> installation/usage was a little misleading(not wrong - just
> misleading).
>
> I have attached a patch that changes this. criticisms, suggestions
> welcome.
>
> Regards,
> Madan.
>
> PS : I have just started using gnus. If you dont find the attached files and/or find them with wrong mimetypes, pl. shout. I will resend. It will also make my mailing more efficient. Thanks.

Thanks! Applied in r17541, with a few tweaks (see comments below).

By the way, your PS above is one long line. You might want to turn on
auto-fill-mode in mail-mode and and message-mode (look for settings of
auto-fill-mode in my .emacs and/or .gnus).

First, log message: I find it much easier when the log message is
included in the same attachment as the patch, using the "[[[ ... ]]]"
convention. I suspect other people will feel the same way (easier to
deal with one file than with two).

> Making the neon installation part of the INSTALL file clearer
>
> INSTALL: Modified the Neon installation instructions to make a
> clear distinction between using neon inline and using it outside
> the subverion build. Reorganized for clarity.

I rewrote the log message like this:

   Make the Neon installation instructions clearer.
   
   * INSTALL: Modify the Neon installation instructions to make a
     clear distinction between using Neon inline and using it outside
     the Subversion build. Reorganize for clarity.

The important changes were: put the sentences in active voice, and put
a period at the end. Consistently capitalize Neon and Subversion (by
the way, it was also inconsistent in the patch itself). Fix spelling
of Subversion. Put two spaces after a sentence-ending period, as
described in hacking.html (this is not a big deal, but it really helps
some of us read more easily, and helps us to use sentence-motion
commands, try M-a and M-e in Emacs for example).

I made various tweaks to the patch, but keeping the overall shape of
your change. See r17541 for details.

Best,
-Karl

-- 
www.collab.net  <>  CollabNet  |  Distributed Development On Demand
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org