[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r17514 - trunk/subversion/libsvn_client

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-11-24 21:36:27 CET

On Thu, 24 Nov 2005 dionisos@tigris.org wrote:

> Author: dionisos
> Date: Thu Nov 24 12:41:02 2005
> New Revision: 17514
>
> Modified:
> trunk/subversion/libsvn_client/blame.c
>
> Log:
> Fix issue #2431 (blame ignores svn:eol-style).
>
> Tested by: zhakov
>
> * subversion/libsvn_client/blame.c
> (file_rev_baton): New members eol_style and eol_str for storing
> the requested file translation type.
> (get_eol_style): New. Function to adjust eol style from propdiff sent.
> (file_rev_handler): See if the file needs translation for the eol style,
> translate if it does.

Have you tested if this has any performance impact for, say many revisions
or large files? I'm concerned because blame fetches a lot of files and
diffs them. If this is a real problem, can't we just add the correct EOL
sequence when outputting the lines (after stripping whatever line endings
there are on the actual lines.) It seems strange to translate each and
every revision of a file just to get the correct EOL characters in the
last one. (Or isn't there a streamy interface to translation that could
be used to avoid the extra tempfile?)

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Nov 24 21:37:17 2005

This is an archived mail posted to the Subversion Dev mailing list.