[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH]: Fix memory leak in diff

From: Daniel Berlin <dberlin_at_dberlin.org>
Date: 2005-11-24 14:47:44 CET

> > {
> > const char *path = APR_ARRAY_IDX (targets, i, const char *);
> > @@ -180,9 +180,9 @@ svn_cl__diff (apr_getopt_t *os,
> >
> > if (! pegged_diff)
> > {
> > - svn_pool_clear (subpool);
> > - target1 = svn_path_join (old_target, path, subpool);
> > - target2 = svn_path_join (new_target, path, subpool);
> > + svn_pool_clear (iterpool);
>
> Why is this pool clearing inside the if statement? This seems to leave
> the leak in the pegged_diff case.

Don't look at meef, i didn't write the code.

I'll fix and test that.

--Dan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Nov 24 14:48:51 2005

This is an archived mail posted to the Subversion Dev mailing list.