[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH]: Fix memory leak in diff

From: Daniel Berlin <dberlin_at_dberlin.org>
Date: 2005-11-24 03:23:07 CET

One of my users noticed that if you specify files seperately to svn
diff, the memory usage goes through the roof.

IE if you do svn diff *.c */*.c on a gcc checkout in the gcc dir, it
uses more than 300 meg of memory.

This is caused by not actually passing the per-iteration pool to our

I also renamed subpool to iterpool by request of Erik, since it is
really cleared every iteration, and renaming it makes this clearer.


Fix memory leak when diff is given multiple files on the command line.

* subversion/clients/cmdlne/diff-cmd.c
  (svn_cl__diff): Rename subpool to iterpool.
  Pass iterpool to children, instead of pool.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Thu Nov 24 03:23:52 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.