[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r17483 - trunk

From: Peter Samuelson <peter_at_p12n.org>
Date: 2005-11-23 01:47:25 CET

[Garrett Rooney]
> > -#!/bin/sh
> > +#!/bin/bash
> > # -*- mode: shell-script; -*-
> > # $Id$
>
> I thought about that, but decided that since systems that use
> something other than bash for /bin/sh usually don't have bash in /bin
> it wouldn't really help much anyway.

I was thinking more as a marker that the script contains bashisms, in
case anyone is ever in the mood to adapt the subversion codebase not to
require bash. (There are a few, but only a few, #!.*/bash scripts in
the corpus - mostly in contrib.) I think it's reasonable to require
any modern system /bin/sh to support POSIX shell syntax - well,
reasonable everywhere except perhaps Solaris - but a lot of Unix
systems still don't have, or particularly want, bash.

> I'm totally not motivated enough to go add autoconf gunk to search
> out the actual location of bash

100% agreed on that part. Much trouble to little benefit.

[Aside: using $(PYTHON) everywhere in the build system might be time
better spent. Last I checked, it was *almost* but not quite possible
to compile subversion on a system with a python which is not
/usr/bin/python.]

Received on Wed Nov 23 01:49:17 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.