Re: [PATCH] Extra integrity test for svnadmin dump/verify (was Re: svnadmin dump/verify not working as expected?)

On Tuesday 22 November 2005 04:54, Malcolm Rowe wrote:
> On Sun, Nov 20, 2005 at 03:10:33PM -0500, John Szakmeister wrote:
> > a consequence though. In this case, it means that if the length of the
> > svndiff was small for a file, that you can no longer dump that revision
> > in your repository (it would error out on both svnadmin verify and
> > svnadmin dump).
>
> If someone comes to svn-dev with a repository that 'works', but fails
> verification due to this problem, how do we repair it, given that 'dump'
> no longer works?

The same we fix other issues: edit the backend data structures. Some of us
have done this on the users@ list a number of times. :-)

> I like the idea of flagging potential problems as soon as possible, but
> not the idea of blocking 'svnadmin dump' when we don't really need to.
> Is there any way we can convert this hard error into a warning? (Yes,
> I realise that might be difficult, given that it's code in libsvn_repos,
> not svnadmin itself).

I'm not a fan of it either, but we already have a precedent for it. Change a
byte in the plain text representation of a file, and you'll run into the same
issue. *shrug*

-John

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Nov 22 11:07:35 2005