On Mon, 21 Nov 2005, Julian Foad wrote:
> Peter, for my interest, could you show me a few warnings of this type from gcc
> 4.0.2? I'd like to have a look at our code in those places, and try to see how
> it differs.
>
Here we go. The problem seems to be that if you pass a variable by
reference to a function whihc is expected to fill in the variable value,
the compiler is pesimistic about this. I can go fixing these if people
don't object. I'm not opposed to shutting up warnings per se. I more want
us to resolve the question before going on and doing this in particular
cases.
../1.3.x/subversion/libsvn_delta/svndiff.c: In function 'decode_window':
../1.3.x/subversion/libsvn_delta/svndiff.c:339: warning: 'op.action_code' may be used uninitialized in this function
../1.3.x/subversion/libsvn_delta/svndiff.c:339: warning: 'op.offset' may be used uninitialized in this function
../1.3.x/subversion/libsvn_delta/svndiff.c:411: warning: 'ninst' may be used uninitialized in this function
../1.3.x/subversion/libsvn_delta/svndiff.c: In function 'read_window_header':
../1.3.x/subversion/libsvn_delta/svndiff.c:658: warning: 'c' may be used uninitialized in this function
../1.3.x/subversion/libsvn_delta/svndiff.c:639: warning: 'c' may be used uninitialized in this function
../1.3.x/subversion/libsvn_delta/svndiff.c:639: warning: 'c' may be used uninitialized in this function
../1.3.x/subversion/libsvn_delta/svndiff.c:639: warning: 'c' may be used uninitialized in this function
../1.3.x/subversion/libsvn_delta/svndiff.c:639: warning: 'c' may be used uninitialized in this function
../1.3.x/subversion/libsvn_subr/path.c: In function 'svn_path_cstring_to_utf8':
../1.3.x/subversion/libsvn_subr/path.c:1236: warning: 'path_is_utf8' may be used uninitialized in this function
../1.3.x/subversion/libsvn_subr/path.c: In function 'svn_path_cstring_from_utf8':
../1.3.x/subversion/libsvn_subr/path.c:1219: warning: 'path_is_utf8' may be used uninitialized in this function
../1.3.x/subversion/libsvn_fs_fs/fs_fs.c: In function 'svn_fs_fs__rev_get_root':
../1.3.x/subversion/libsvn_fs_fs/fs_fs.c:1142: warning: 'root_id' may be used uninitialized in this function
../1.3.x/subversion/libsvn_fs_fs/fs_fs.c: In function 'rep_read_contents':
../1.3.x/subversion/libsvn_fs_fs/fs_fs.c:1483: warning: 'cwindow' may be used uninitialized in this function
../1.3.x/subversion/libsvn_fs_fs/fs_fs.c: In function 'read_representation':
../1.3.x/subversion/libsvn_fs_fs/fs_fs.c:1252: warning: 'rep_args' may be used uninitialized in this function
../1.3.x/subversion/libsvn_fs_fs/fs_fs.c: In function 'commit_body':
../1.3.x/subversion/libsvn_fs_fs/fs_fs.c:3852: warning: 'start_node_id' may be used uninitialized in this function
../1.3.x/subversion/libsvn_fs_fs/fs_fs.c:3852: warning: 'start_copy_id' may be used uninitialized in this function
../1.3.x/subversion/libsvn_fs_fs/revs-txns.c: In function 'svn_fs_fs__get_txn_ids':
../1.3.x/subversion/libsvn_fs_fs/revs-txns.c:131: warning: 'txn' may be used uninitialized in this function
../1.3.x/subversion/libsvn_fs_fs/tree.c: In function 'find_youngest_copyroot':
../1.3.x/subversion/libsvn_fs_fs/tree.c:2748: warning: 'path_parent' may be used uninitialized in this function
../1.3.x/subversion/libsvn_fs_fs/tree.c:2748: warning: 'path_parent' may be used uninitialized in this function
../1.3.x/subversion/libsvn_fs_fs/tree.c:2748: warning: 'path_parent' may be used uninitialized in this function
../1.3.x/subversion/libsvn_fs_fs/tree.c:2748: warning: 'path_parent' may be used uninitialized in this function
../1.3.x/subversion/libsvn_fs_fs/tree.c:2748: warning: 'path_parent' may be used uninitialized in this function
../1.3.x/subversion/libsvn_fs_fs/tree.c:2748: warning: 'path_parent' may be used uninitialized in this function
../1.3.x/subversion/libsvn_fs_fs/tree.c:2748: warning: 'path_parent' may be used uninitialized in this function
../1.3.x/subversion/libsvn_fs_fs/tree.c:2748: warning: 'path_parent' may be used uninitialized in this function
../1.3.x/subversion/libsvn_fs_base/revs-txns.c: In function 'svn_fs_base__set_rev_prop':
../1.3.x/subversion/libsvn_fs_base/revs-txns.c:243: warning: 'txn_id' may be used uninitialized in this function
../1.3.x/subversion/libsvn_fs_base/revs-txns.c:242: warning: 'txn' may be used uninitialized in this function
../1.3.x/subversion/libsvn_fs_base/revs-txns.c: In function 'svn_fs_base__rev_get_root':
../1.3.x/subversion/libsvn_fs_base/revs-txns.c:118: warning: 'txn' may be used uninitialized in this function
../1.3.x/subversion/libsvn_fs_base/revs-txns.c: In function 'txn_body_revision_proplist':
../1.3.x/subversion/libsvn_fs_base/revs-txns.c:178: warning: 'txn' may be used uninitialized in this function
../1.3.x/subversion/libsvn_repos/load.c: In function 'svn_repos_parse_dumpstream2':
../1.3.x/subversion/libsvn_repos/load.c:486: warning: 'version' may be used uninitialized in this function
../1.3.x/subversion/libsvn_repos/load.c:528: warning: 'actual_prop_length' may be used uninitialized in this function
../1.3.x/subversion/libsvn_ra_svn/client.c: In function 'ra_svn_open':
../1.3.x/subversion/libsvn_ra_svn/client.c:616: warning: 'args' may be used uninitialized in this function
../1.3.x/subversion/libsvn_ra_svn/client.c:614: warning: 'conn' may be used uninitialized in this function
../1.3.x/subversion/libsvn_wc/adm_files.c: In function 'svn_wc_ensure_adm2':
../1.3.x/subversion/libsvn_wc/adm_files.c:1119: warning: 'exists_already' may be used uninitialized in this function
../1.3.x/subversion/libsvn_ra_dav/session.c: In function 'svn_ra_dav__open':
../1.3.x/subversion/libsvn_ra_dav/session.c:665: warning: 'timeout' may be used uninitialized in this function
../1.3.x/subversion/libsvn_ra_dav/session.c:666: warning: 'debug' may be used uninitialized in this function
../1.3.x/subversion/libsvn_ra_dav/session.c: In function 'svn_ra_dav__lock':
../1.3.x/subversion/libsvn_ra_dav/session.c:1200: warning: 'lock' may be used uninitialized in this function
../1.3.x/subversion/clients/cmdline/lock-cmd.c: In function 'svn_cl__lock':
../1.3.x/subversion/clients/cmdline/lock-cmd.c:85: warning: 'comment' may be used uninitialized in this function
../1.3.x/subversion/svnadmin/main.c: In function 'subcommand_dump':
../1.3.x/subversion/svnadmin/main.c:581: warning: 'stdout_stream' may be used uninitialized in this function
../1.3.x/subversion/svnadmin/main.c: In function 'subcommand_load':
../1.3.x/subversion/svnadmin/main.c:671: warning: 'stdin_stream' may be used uninitialized in this function
../1.3.x/subversion/svnserve/serve.c: In function 'diff':
../1.3.x/subversion/svnserve/serve.c:1209: warning: 'versus_path' may be used uninitialized in this function
../1.3.x/subversion/svnserve/serve.c: In function 'switch_cmd':
../1.3.x/subversion/svnserve/serve.c:1166: warning: 'switch_path' may be used uninitialized in this function
../1.3.x/subversion/svnserve/serve.c: In function 'link_path':
../1.3.x/subversion/svnserve/serve.c:483: warning: 'fs_path' may be used uninitialized in this function
../1.3.x/subversion/tests/libsvn_delta/random-test.c: In function 'random_combine_test':
../1.3.x/subversion/tests/libsvn_delta/random-test.c:512: warning: 'seed' may be used uninitialized in this function
...
Thanks,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 21 21:55:17 2005