[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH]: Change sort order for 'svn diff'

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-11-20 22:58:44 CET

On Sun, 20 Nov 2005, Malcolm Rowe wrote:

> On Sun, Nov 20, 2005 at 12:59:18PM -0800, Kean Johnston wrote:
> > >I am curious about the ordering you picked: was there any
> > >(performance? usability?) reason for it? I guess if I had to come up
> > >with an ordering for diff myself, I'd just have picked 'sort by name',
> > >not 'files first, directories second, sorted by name'.
> > >
> > [...]
> >
> > Lets take a real-world example. Suppose I am working on gcc,
> > and I have made changes that span most of its sub-trees. If
> > we were to sort the entire list alphabetically, I would have
> > my diff to calls.c followed by patches to files in config/i386
> > followed by the diff to toplev.c. But patches in subdirectories
> > tend to be logically grouped.
>
> Ah, yes. That does make perfect sense, thanks!
>
I'm not opposed to making output of svn commands sorted (OTOH; I like it a
lot). I just want to point out something that might not be obvious to
everyone.

The deterministic order will be localce dependent. That's a good thing,
IMO. The only problem is that if you do sorting on the server, you will
depend on the locale of the server process.. That might not be a big
problem, but it will be confusing to some people. I honestly don't know
what to do about it. Communicating the locale information from client to
server isn't trivial to do portably and changing the server process locale
as per the client's preferences isn't always an option. Think
multitheading servers on Unix.

Just wanted to make sure people are aware of this.

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Nov 20 22:59:27 2005

This is an archived mail posted to the Subversion Dev mailing list.