[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r17456 - trunk/subversion/libsvn_wc

From: Erik Huelsmann <e.huelsmann_at_gmx.net>
Date: 2005-11-20 19:02:46 CET

> On Sun, Nov 20, 2005 at 05:31:04AM -0600, dionisos@tigris.org wrote:
> > * subversion/libsvn_wc/props.c: Silence a gcc 'uninitialized' warning.
> >
> > Modified: trunk/subversion/libsvn_wc/props.c
> > Url:
>
http://svn.collab.net/viewcvs/svn/trunk/subversion/libsvn_wc/props.c?rev=17456&p1=trunk/subversion/libsvn_wc/props.c&p2=trunk/subversion/libsvn_wc/props.c&r1=17455&r2=17456
> >
>
==============================================================================
> > --- trunk/subversion/libsvn_wc/props.c (original)
> > +++ trunk/subversion/libsvn_wc/props.c Sun Nov 20 05:30:58 2005
> > @@ -436,7 +436,7 @@
> > for (i = 0; i < propchanges->nelts; i++)
> > {
> > const char *propname;
> > - svn_string_t *conflict_description;
> > + svn_string_t *conflict_description = NULL; /* Silence gcc warning
> */
> > const svn_prop_t *incoming_change;
> > const svn_string_t *from_val, *to_val, *working_val;
> > svn_boolean_t is_normal, conflict = FALSE;
>
> Glad to see this bothered someone else - I've had something similar in my
> tree for ages. My version removed 'conflict', replacing 'if (conflict)'
> with 'if (conflict_description != NULL)'.
>
> Would anyone object if I checked that in?

Definitely not. I think it's a good thing not to duplicate data; I guess
I'm saying: please do.

bye,

Erik.

-- 
10 GB Mailbox, 100 FreeSMS/Monat http://www.gmx.net/de/go/topmail
+++ GMX - die erste Adresse für Mail, Message, More +++
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Nov 20 19:03:16 2005

This is an archived mail posted to the Subversion Dev mailing list.