[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] improved bash completion v4

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-11-19 23:33:12 CET


I (Julian Foad) wrote:
> There is a lot of good stuff in here and it is time I committed it, but
> I wish you could stop adding new features to it at the same time as
> fixing bugs. Each new feature brings more bugs.

Perhaps I should briefly try to explain why I sound a bit ... frustrated or
something. I didn't mean to be rude.

I have not been using the bash completion for Subversion until now, though I
think it's a good idea. I reviewed your patch just because it was there and I
found it interesting.

I have been a bit uncomfortable because I am not completely sure whether most
users will like this rather significant change of direction in its development,
this "guiding the user" to build up a command rather than just presenting all
the possible options at each point. I wish someone else had commented on that
aspect, but they haven't. The idea seems to work well, so I decided to accept
it, and I have encouraged you to fix bugs and submit new versions.

Now that I have started using this Bash completion I will probably continue, as
long as it only helps me and does not do anything that gets in the way of me
composing a Subversion command. It is fine if it does not suggest any
completions in a place where it could have done so: that is just as if I were
not using the feature. It would be very bad if it inserted an inappropriate
completion or messed up my screen: that would be annoying and I would no longer
trust it to help me. That is why I am being quite strict about bugs.

I know that you have put a lot of effort into this patch, re-submitting it
several times already, and I want to be able to commit it so that you can see
your work accepted and being used. Therefore I'd like you to concentrate on
getting it to do a limited number of things accurately and consistently. Then
I can commit it, and then you can work on adding more features or extending the
number of option values it recognises if you want to.


- Julian

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Nov 19 23:33:55 2005

This is an archived mail posted to the Subversion Dev mailing list.