[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Path searching in svn_io_start_cmd

From: <kfogel_at_collab.net>
Date: 2005-11-18 16:27:44 CET

Julian Foad <julianfoad@btopenworld.com> writes:
> From svn_io_start_cmd():
>
> > * @a inherit sets whether the invoked program shall inherit its environment or
> > * run "clean".
>
> > /* Make sure we invoke cmd directly, not through a shell. */
> > apr_err = apr_procattr_cmdtype_set (cmdproc_attr,
> > inherit?APR_PROGRAM_PATH:APR_PROGRAM);
>
> That should be "APR_PROGRAM_ENV", not "APR_PROGRAM_PATH", else
> path-search is enabled as well as env. But didn't we specifically
> want path-search for our external "diff" support? Is that diff
> support relying on an undocumented feature (path search)?
>
> Something's wrong. Anyone care to decide what?

Are they bitmasks, and if so, shouldn't we do both? That is:

    apr_err = apr_procattr_cmdtype_set
              (cmdproc_attr,
               inherit ? (APR_PROGRAM_ENV | APR_PROGRAM_PATH) : APR_PROGRAM);

(I'm not sure if the feature is "undocumented" so much as "assumed" :-) ).

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Nov 18 17:48:38 2005

This is an archived mail posted to the Subversion Dev mailing list.