[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Move multiple files, step 1, version 1

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-11-18 01:59:59 CET

Hyrum K. Wright wrote:
>
> I think that is will be easier to first implement move, which only has
> two cases (WC->WC and URL->URL), and then go back and implement copy,
> which has four.

OK.

>>Presumably, for multiple source paths, the destination must be a
>>directory into which the sources will be moved, whereas for a single
>>item it can be the new name for the item. (This part of the doc string,
>>about "dst_path", is already ambiguous; I've just posted a patch to
>>clarify it.)
>>
>>I think we might well need to use two separate functions, one for moving
>>(and possibly renaming) a single item, and one for moving multiple (one
>>or more) items without renaming them. Otherwise, if only one source
>>item is specified, how do we know whether the destination path or url
>>represents the new _name_ for the item or the new _directory_ in which
>>to place it?
>
> Wouldn't it be possible to just check and see if the destination is a
> target when there is more than one source? If that case were not met,
> we could error.

(I assume you mean "directory" instead of "target".)

No, I don't think we can just check, because I think the "multiple files" mode
needs to work in the same way regardless whether the number of files is one or
more than one, and the way it needs to work (the destination always being a
directory in which to put the sources) is incompatible with the current
semantics for one file.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Nov 18 02:00:48 2005

This is an archived mail posted to the Subversion Dev mailing list.