[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r17377 - trunk

From: Max Bowsher <maxb1_at_ukf.net>
Date: 2005-11-16 11:09:02 CET

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Malcolm Rowe wrote:
> On Tue, Nov 15, 2005 at 06:36:49PM -0600, maxb@tigris.org wrote:
>
>>--- trunk/Makefile.in (original)
>>+++ trunk/Makefile.in Tue Nov 15 18:36:48 2005
>
>
>>+extraclean-swig-headers: clean-swig-headers
>
>
> I know you didn't add this rule, but shouldn't this be invoked by 'make
> extraclean'? From what I can see, it isn't. (Ditto clean-swig-headers
> and 'make clean').

More changes to come - I'm in progress of extracting and committing
modular changes from a mixed mess of changes I have in a WC.

In other words, yes, and I'll get to this at some point today.

>> clean-swig-rb:
>> rm -rf $(SWIG_RB_DIR)/test/repos $(SWIG_RB_DIR)/test/wc
>>+ if test $(abs_srcdir) != $(abs_builddir); then \
>>+ rm -f $(SWIG_RB_DIR)/*.c; \
>>+ fi
>> for d in $(SWIG_RB_DIR) $(SWIG_RB_DIR)/libsvn_swig_ruby; \
>> do \
>> cd $$d; \
>> rm -rf *.lo *.la *.o .libs; \
>> done
>
>
>>+extraclean-swig-rb: clean-swig-rb
>>+ rm -f $(top_srcdir)/subversion/bindings/swig/ruby/*.c
>
>
> If I'm understanding this right, the SWIG clean-* rules are performing
> the equivalent of the extraclean-* rules if you run them in a VPATH build.
> Why is that?

Because it is possible for the files in question to be generated either
by autogen.sh --release, or by simple make. Depending on which happens,
it is appropriate to clean them at different times.

In a VPATH build, we can tell which mode they were built in based on
whether they are in the srcdir or the builddir. In a non-VPATH build, we
can't tell, so we just leave the cleaning until extraclean
unconditionally. (Though, I was talking with djames on IRC yesterday,
and we were thinking of recording whether the srcdir was in release mode
in build-outputs.mk, so we could do this better.)

> (and why are we using $SWIG_RB_DIR in one place and a hard-coded srcdir
> path in another?) Have I just completely misunderstood what's going
> on here?

The SWIG_??_DIR variables are only shorthand. And yes, sometimes they
are used, sometimes they are not. It doesn't really matter.

Max.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Cygwin)

iD8DBQFDewU9fFNSmcDyxYARAsXMAJ9ItYQX6S5MYYGDB1YsJtW476I8uQCfUQPj
ssCGp+bvdGAAupiY1yV8Bpo=
=Kq2b
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Nov 16 11:09:57 2005

This is an archived mail posted to the Subversion Dev mailing list.