[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn_io_file_rename preserves *destination* file permission on Windows

From: Ivan Zhakov <chemodax_at_gmail.com>
Date: 2005-11-15 13:56:10 CET

On 11/15/05, Branko Čibej <brane@xbc.nu> wrote:
> Ivan Zhakov wrote:
>
> >On 11/15/05, Erik Huelsmann <ehuels@gmail.com> wrote:
> >
> >
> >>On 11/15/05, Ivan Zhakov <chemodax@gmail.com> wrote:
> >>
> >>
> >>>On 11/15/05, Branko Čibej <brane@xbc.nu> wrote:
> >>>
> >>>
> >>>>Erik Huelsmann wrote:
> >>>>
> >>>>
> >>>>>So, I suppose I should be testing trunk on a windows box and see what
> >>>>>happens if I change svn_io_file_rename...
> >>>>>
> >>>>>
> >>>>>
> >>>>Something bad, I'm pretty sure, or I wouldn't have made the original
> >>>>commit. :)
> >>>>
> >>>>
> >>>I have just removed setting destination read-only after rename and all
> >>>tests passes on Windows (except propt_tests.py 16 which is failling
> >>>before change).
> >>>
> >>>
> >>Could you reduce svn_wc__prep_file_for_replacement to 'return
> >>SVN_NO_ERROR;' and see if tests still pass? (Yes, with the changed
> >>svn_io_file_rename please.)
> >>
> >>Before deciding to really rip that specific part of the code, it would
> >>be good to find out if any tests were created to test for the
> >>semantics Branko is referring to (not necessarily asking you to do
> >>that though).
> >>
> >>
> >All tests pass with no-op svn_wc__prep_file_for_replacement and
> >changed svn_io_file_rename. What do you think about this?
> >
> >
> Please donćt even consider ripping that code out before you're 100% sure
> it's not needed (any more). I certainly didn't make those changes for
> fun. They were needed at the time.
Of course, I am understand that you changed it for something. I want
get to know for what this done. For present time I haven't ideas.

--
Ivan Zhakov
Received on Tue Nov 15 13:58:46 2005

This is an archived mail posted to the Subversion Dev mailing list.