[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [wc-propcaching]: Cached proprety existence, take two

From: Ivan Zhakov <chemodax_at_gmail.com>
Date: 2005-11-15 10:06:35 CET

On 11/15/05, Peter N. Lundblad <peter@famlundblad.se> wrote:
> On Mon, 14 Nov 2005, Daniel Berlin wrote:
>
> > > No need to clear the entry first. That will just confuse readers.
> >
> > Actually, you do need to.
> >
> > It will live on from tmp_entry above.
> >
> So, you have a tmp_entry, you clear it and then assign to the only field
> that will be used by the following call. How can that be necessary?
>
> BTW, you can leave this svn_wc_merge_prop_diffs function alone for now.
> I've left a TODO at the top (after you created this patch). We should look
> into reimplementing this in terms of svn_wc__install_props.
No problem to implement svn_wc_merge_prop_diffs in terms of
svn_wc__install_props, but ideally we should implement it using
svn_wc__merge_props with server_baseprops NULL.

--
Ivan Zhakov
Received on Tue Nov 15 10:07:49 2005

This is an archived mail posted to the Subversion Dev mailing list.