[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: r17214, JavaHL thread local storeage and reentrant calls

From: Mark Phippard <markp_at_softlanding.com>
Date: 2005-11-14 21:40:48 CET

rooneg@gmail.com wrote on 11/14/2005 03:23:54 PM:

> On 11/14/05, Andrew Vaughan <ajv-lists@netspace.net.au> wrote:
>
> > (I haven't studied the code, just skimmed the log, and read your
explanation
> > above). There should be no problems with either green or native
threads,
> > _iff_ the Java code is properly synchronized. (eg. either using
> > SVNClientSynchronized.java or synchronizing on some other Object
themselves.)
>
> But what if they were using different SVNClientSynchronized objects
> entirely? It seems like there are any number of different ways you
> could have two separate threads calling into JavaHL without any
> locking at all between them, which would mean you're vulnerable to
> this sort of problem.

I do not believe that SVNClientSynchronized is synchronizing on a specific
instance of the class. If it were, then it wouldn't be thread safe at
all. It is synchrnonizing on a static instance of the .class which I
believe will apply to all instances of the class and therefore all
threads.

We use SVNClientSynchronized in Subclipse.

Mark

_____________________________________________________________________________
Scanned for SoftLanding Systems, Inc. and SoftLanding Europe Plc by IBM Email Security Management Services powered by MessageLabs.
_____________________________________________________________________________

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 14 21:42:06 2005

This is an archived mail posted to the Subversion Dev mailing list.