Re: [PATCH} move and extend 'svnversion' functionnality in libsvn_wc

Fabien COELHO wrote:
>
>> However, your patch does not just move it; your patch also extends it.
>> Please split this into two separate patches. (Obviously it will
>> matter which one is applied first.)
>
> That can be done.
>
>> For the patch that extends the functionality of svnversion, please say
>> what the extensions are and why you want them.
>
> Two patches would change the signature of the result structure

That depends on the order in which you make the two patches. If you make the
enhancements first, then there won't be any such change within libsvn_wc.

> introduced added to libsvn_wc. Isn't it an issue that the signature of a
> library function is changed twice in two patches? No problem with me,
> just that I would expect lib functions to be very stable.

It doesn't matter if they change during development of a new minor version
(Subversion v1.4). It only matters if the API is introduced in one version and
(e.g. 1.4) and then has to be changed in a later version (>= 1.5).

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 14 19:55:07 2005