[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: r17214, JavaHL thread local storeage and reentrant calls

From: Mark Phippard <markp_at_softlanding.com>
Date: 2005-11-14 19:21:51 CET

rooneg@gmail.com wrote on 11/14/2005 01:00:45 PM:

> So is this something we need to care about? I really don't know
> enough about Java/JNI to say one way or the other, but it seems weird
> enough to be concerned about.

I am also somewhat involved in this. Let me just share the bits I know
....

In debugging the original problem for Patrick I determined that in the
case of Subclipse (which was triggering the problem) this wasn't a thread
issue, but a reentry issue. As an example, Subclipse would run checkout,
which run the native checkout code, which would send notifications back to
Java which would call back into the code to run getAdminDirectory(). This
would crash. Talking to Patrick I realized that this was also likely the
problem with another crash scenario. When we tried to add support in
Subclipse for cancelling an operation it would crash. I just assumed
JavaHL "worked" and the bug was in Subclipse so I set it aside and did not
report it.

I applied Patrick's patch to the 1.3.x branch on Windows and built it. It
passed all of the JUnit tests. I then put the code into Subclipse and
added reentry code. Namely, I removed all internal caching of calls to
getAdminDirectory() and isAdminDirectory(). I also put the cancel
operation code back in. With Patrick's patch everything appears to work
properly now. Having support for cancel has been one of the top requests
for Subclipse so it would be good to be able to add this feature.

Unfortunately, I cannot comment on your concerns. I can only give you
these observations.

Thanks

Mark

_____________________________________________________________________________
Scanned for SoftLanding Systems, Inc. and SoftLanding Europe Plc by IBM Email Security Management Services powered by MessageLabs.
_____________________________________________________________________________

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 14 19:45:52 2005

This is an archived mail posted to the Subversion Dev mailing list.