[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [wc-propcaching]: Cache existence of certain properties

From: Daniel Berlin <dberlin_at_dberlin.org>
Date: 2005-11-11 15:53:16 CET

On Fri, 2005-11-11 at 17:39 +0300, Ivan Zhakov wrote:
> On 11/10/05, Daniel Berlin <dberlin@dberlin.org> wrote:
> > This patch adds the ability to cache whether certain properties exist in
> > the entries file. It does not cache their values.
> >
> > This massively speeds up operations like update and commit, which need
> > to know about certain properties on each file or directory.
> >
> > The implementation simply stores an extra attribute in the entries file,
> > which is a string containing the names of the properties that are
> > cached, and exist for a file/directory.
> >
> > It was decided to use a single string for simplicity, and because using
> > multiple attributes doesn't actually buy you anything (in any case,
> > adding or removing to the list of cached properties will require format
> > upgrades).
> >
> > The string has no particular ordering properties, and is space
> > separated.
> >
> > The list of cached properties is also stored as a single string, comma
> > separated. A new function, svn_wc_cached_properties, will return this
> > list of cached properties. It is kept as a string again for simplicity.
> > Only the things updating the props file want to be able to split it into
> > an array, and do so. The getter functions simply want to know if the
> > property they are asking about is in the list, and we can just use
> > strstr for that.
> >
> I see problem here. For example if in future we will have property
> "svn:needs-lock" and "svn:need". strstr() will find substring
> "svn:need" in case when property "svn:needs-lock" exists. I consider
> this is problem.

Uh, why would we do such a thing?
Anyway, if you are really concerned, i'll make it split the string into
an array and search it, but it seems kinda a waste :)

>
> PS: Also you patch contain tab symbols, Subversion team don't use tab
> spaces in sourcecode.
>
Yeah, i fixed this already (my emacs regexp wasn't catching this dir).

> --
> Ivan Zhakov

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Nov 11 15:54:50 2005

This is an archived mail posted to the Subversion Dev mailing list.