[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r17277 - in trunk/subversion: include libsvn_fs_base libsvn_repos libsvn_subr libsvn_wc

From: Erik Huelsmann <ehuels_at_gmail.com>
Date: 2005-11-10 08:16:14 CET

On 11/10/05, Julian Foad <julianfoad@btopenworld.com> wrote:
> Philip Martin wrote:
> > dionisos@tigris.org writes:
> >
> >>Author: dionisos
> >>Date: Wed Nov 9 14:11:10 2005
> >>New Revision: 17277
> >
> >>--- trunk/subversion/libsvn_wc/adm_files.c (original)
> >>+++ trunk/subversion/libsvn_wc/adm_files.c Wed Nov 9 14:11:10 2005
>
> >>+svn_error_t *
> >>+svn_wc__adm_write_version_file (const char *adm_path, apr_pool_t *pool)
> >>+{
> >>+ return svn_io_write_version_file2
> >>+ (extend_with_adm_name (adm_path, NULL, FALSE, pool,
> >>+ SVN_WC__ADM_FORMAT, NULL),
> >>+ SVN_WC__VERSION,
> >>+ _(" DON'T EDIT FILES IN THIS AREA\n"
> >>+ " MANUAL CHANGES WILL BREAK YOUR WORKING COPY\n\n"),
> >>+ pool);
> >>+}
> >
> > "Will" is too strong, manual changes *may* break the working copy but
> > it's not inevitable.
>
> Furthermore, a warning that doesn't say where it came from or on whose
> authority it is issued is just annoying. The existing README text would be better:
>
> This is a Subversion working copy administrative directory.
> Visit http://subversion.tigris.org/ for more information.
>
>
> > I think this warning is pointless. I'd be surprised is someone
> > who is considering editing the entries files is going to be put off by
> > a warning in the format file.
>
> Indeed.
>
> And why should we want such a message in the "format" file rather than, say,
> the "entries" file? Do we have reason to expect people to find it there?
>
>
> And what happened on the first "+" line in this diff hunk of the commit?

Removal of a trailing space.

But both maxb and djames had objections too. So, I guess I'll revert.

Thanks for taking your time to review and comment.

bye,

Erik.
Received on Thu Nov 10 08:17:32 2005

This is an archived mail posted to the Subversion Dev mailing list.