[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Does the delta editor guarantee that propchangess are precomposed?

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2005-11-08 14:40:13 CET

Afternoon, list,

In one or two places in libsvn_wc/diff.c, we rely on the fact that
propchanges are 'precomposed'. That is, if a single node has property
changes { [A=>x, B=>y], [A=>z] } over two revisions, the delta editor will
only deliver (via change_file_prop() or change_dir_prop()) the changes
[A=>z, B=>y], rather than call the function twice, once for each batch
of changes.

Is this behaviour currently guaranteed by the tree-delta interface? (and
if so, where?).

If not, would it be better to change the tree-delta interface so it _is_
guaranteed (i.e., document it in svn_delta.h) [and can we make that change
without breaking compatibility?], or would it be better to 'pessimise'
libsvn_wc so that it can deal with the possibility that propchanges are
delivered in batches, even though they aren't (or rather, don't appear
to be).

Regards,
Malcolm

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Nov 8 14:41:01 2005

This is an archived mail posted to the Subversion Dev mailing list.