[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r17181 - trunk/subversion/libsvn_wc

From: Erik Huelsmann <ehuels_at_gmail.com>
Date: 2005-11-07 19:31:13 CET

On 11/5/05, Branko Čibej <brane@xbc.nu> wrote:
> David James wrote:
> > On 11/5/05, Erik Huelsmann <ehuels@gmail.com> wrote:
> >
> >>> (If someone on Windows uses a diff tool that can't handle a NUL: as a
> >>> file name, they can write a wrapper for it. I don't think we should
> >>> cater to every half-ported utility in the world.)
> >>>
> >> Great! Well, I was already planning to use SVN_NULL_DEVICE_NAME (but
> >> was looking in the wrong place: APR). Glad we have even discussed it
> >> now and having been pointed in the right direction.
> >>
> >> Consider it implemented!
> >>
> > Is it possible to implement this behaviour without breaking external diff tools?
> >
> As I said, any properly implemented external diff tool should do the
> right thing with "NULL:" -- if it doesn't, it's broken already. We could
> create an empty file before calling an external tool with a "NULL:" file
> name argument and replacing the name, but I don't think we should bother.
>
> A Windows app that doesn't handle " NUL:" correctly is as broken as one
> that can't tell the difference between "C:foo.txt" and "C:\foo.txt". I
> suspect this will only happen in tools that have been ported to Windows
> from (usually) Unix -- and whoever ported it can fix the bug. Not to
> mention that there's a really trivial workaround.

Turns out we weren't exactly without problems either. I'll revert the
commit and document in the code why that was necessary.

We've already reduced the number of temp files from 1 per directory to
1 per diff/commit.

bye,

Erik.
Received on Mon Nov 7 19:35:46 2005

This is an archived mail posted to the Subversion Dev mailing list.