[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn trunk r17230: FAIL (win32 ra_local fsfs)

From: Erik Huelsmann <ehuels_at_gmail.com>
Date: 2005-11-07 13:34:25 CET

> >Grr! Seems I'll need to have another look at what's currently done
> >with the NUL file. Anybody who has an idea why svn would need
> >attributes from an empty file to diff against?
>
> I don't know why *we* need that, but this sends a pretty strong signal to
> me. Julian seems to have a good point here. NUL on Windows doesn't seem
> that much like a file as it is on Unix. An external diff program could
> well want file attributes on its input file.
>
> It seems like we should avoids this smallish optimization and just create
> an empty temporary file per diff/merge invocation instead. That's not a
> big deal, and we avoid breaking peoples use of external differs.

You're right there.

> Erik, don't forget to leave a note in the code about why we don't use the
> null device for this purpose.

Heh. ok. Will revert and leave the note.

BTW: There are many other cleanups to be done to libsvn_wc, so no
problem there. Also, our current scheme creates only 1 temp file,
whereas before every dir had one which is already a significant
cleanup.

bye,

Erik.
Received on Mon Nov 7 13:39:45 2005

This is an archived mail posted to the Subversion Dev mailing list.