[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r17190 - trunk/subversion/libsvn_wc

From: Greg Stein <gstein_at_lyra.org>
Date: 2005-11-07 02:55:19 CET

On Mon, Nov 07, 2005 at 01:15:14AM +0000, Julian Foad wrote:
> [...]
> >>Daniel, it's great that you're so quick to come up with a new fix, but
> >>please repost the patch with its log message (and "[PATCH]" in the
> >>subject line) and hold off committing until tomorrow to give the weekday
> >>workers a chance to review it and check whether it's the right fix.
> >
> >Julian: I don't know what gives you the idea that what i say means i
> >wouldn't follow the rules in hacking.html, but i have in the past, and
> >will in the future.
> Oops. I realised that was a bit ... inflammatory? presumptuous? ... as
> soon as I sent it. Sorry, but I got the impression you were going to
> commit it within minutes.

Also, given that there were problems with his original commit, then
why shouldn't he go ahead and try to fix them in real time? It isn't
like his commits will break things further, no?

I don't think it would be advisable to get into a mode of "every
change must be posted for review first." It *really* slows down a
project. Not saying you're recommending that, but that is how I read
this request.


Greg Stein, http://www.lyra.org/
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 7 02:52:56 2005

This is an archived mail posted to the Subversion Dev mailing list.