[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r17181 - trunk/subversion/libsvn_wc

From: Erik Huelsmann <ehuels_at_gmail.com>
Date: 2005-11-05 14:07:25 CET

On 11/5/05, Peter N. Lundblad <peter@famlundblad.se> wrote:
> On Thu, 3 Nov 2005 dionisos@tigris.org wrote:
>
> > Author: dionisos
> > Date: Thu Nov 3 16:37:13 2005
> > New Revision: 17181
> >
> > Modified:
> > trunk/subversion/libsvn_wc/adm_files.c
> > trunk/subversion/libsvn_wc/adm_files.h
> > trunk/subversion/libsvn_wc/diff.c
> > trunk/subversion/libsvn_wc/wc.h
> >
> > Log:
> > Remove creation and use of 'empty-file' from the .svn/ area.
> >
> > Note:
> > Normally this would require a wc-format bump, but since we already have
> > a post-1.3 format bump, there is currently no need.
> >
> > * subversion/libsvn_wc/wc.h: Remove the SVN_WC__ADM_EMPTY_FILE define.
> >
> > * subversion/libsvn_wc/adm_files.h
> > * subversion/libsvn_wc/adm_files.c
> > Remove the empty file API and make sure 'empty-file' isn't created
> > in new working copies anymore.
> >
> > * subversion/libsvn_wc/diff.c (edit_baton): Add an 'empty_file' field
> > for caching the name of the generated empty file.
>
> I've always wondered why we don't use the platforms null device for this.
> We have SVN_NULL_DEVICE_NAME which we use to provide an stdin file for
> hook scripts already. May it cause problems for external diffs when it is
> not a regular file?

I have *no* idea. I thought I had seen something like a null device
define, but went looking for it in APR (why isn't it in APR?!)

We'd have to try. On unix, I can't imagine it not working, but have no
idea on other platforms... (I'd sure like to try though!)

bye,

Erik.
Received on Sat Nov 5 14:08:41 2005

This is an archived mail posted to the Subversion Dev mailing list.