[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r17190 - trunk/subversion/libsvn_wc

From: Daniel Berlin <dberlin_at_dberlin.org>
Date: 2005-11-05 00:36:16 CET

> Is that the right thing to do? It doesn't have a regression test so
> I'm not sure what behaviour you are trying to achieve.
>
> $ svnadmin create repo
> $ svn co file://`pwd`/repo wc
> $ echo xxx > wc/foo
> $ svn add wc/foo
> $ svn ci -m "" wc
> $ svn rm wc/foo
> $ svn diff -r0 wc
>
> Before your change I get
>
> $ svn diff -r0 wc
> ../svn/subversion/libsvn_subr/io.c:2219: (apr_err=2)
> svn: Can't open file 'wc/foo': No such file or directory
>
> that's obviously a bug, with you change I get
>
> $ svn diff -r0 wc
> Index: /tmp/tmp
> ===================================================================
> Index: wc/foo
> ===================================================================
> --- wc/foo (revision 0)
> +++ wc/foo (working copy)
> @@ -1 +0,0 @@
> -xxx
>
> It's that really the correct output?

That's not the output i get, but i've got an external diff
configured :(

> There are two diffs: first an
> empty diff, the /tmp/tmp part, and then a second diff, the wc/foo
> part, that represents the local change. I suppose it's better than it
> was, but I'm not sure it's correct.

So what would you expect?

Only the "wc/foo" part?

If so, that's simple enough, and i'll add a regression test to verify it
ends up like that.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Nov 5 00:37:01 2005

This is an archived mail posted to the Subversion Dev mailing list.