Re: svn commit: r17171 - trunk/subversion/libsvn_wc

On Fri, Nov 04, 2005 at 01:13:24PM -0800, Garrett Rooney wrote:
> On 11/4/05, Malcolm Rowe <malcolm-svn-dev@farside.org.uk> wrote:
> > > EXTRA_CFLAGS='-Wall -Werror'
> > > export EXTRA_CFLAGS
> >
> > That's not a bad idea, though I wonder if it makes sense to enable this
> > by default (in --enable-maintainer-mode)? (assuming that they default
> > build doesn't generate any errors with -Wall, which I don't think it does)
> >
> > Or is that too radical?
>
> If we did do it, it could only be when the compiler is GCC, and even

Yes, that's clear (--enable-maintainer-mode already sets a couple of
GCC-specific warnings - like -Wshadow).

> then, there are systems that produce warnings through no fault of our
> code, which would make this problematic.
>

Well, that was actually something I wondered about: are there GCC versions
that produce warnings with -Wall for our codebase? (gcc 3.3.6 doesn't,
but I wouldn't be too surprised if later versions did).

What I'd quite like is to be able to 'lock in' the '-Wall -Werror'
choice at configure time, so that I don't have to remember it.
"./configure CFLAGS='-Wall -Werror'" almost works, except that something
in APR's configure test can't deal with that (and, thinking about it,
that probably means it's a Bad Idea to even try).

--enable-really-strict-maintainer-mode? --with-extra-cflags=...?

Regards,
Malcolm

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Nov 4 22:44:33 2005