Re: [PATCH] Issue #2419: 'svn rm' of schedule add leaves working props file

Madan U Sreenivasan <madan@collab.net> writes:

> +#----------------------------------------------------------------------
> +def removal_schedule_added_props(sbox):
> + "removal of schedule added file with properties"
> +
> + sbox.build()
> +
> + wc_dir = sbox.wc_dir
> + newfile_path = os.path.join(wc_dir, 'newfile')
>
> + # create new fs file
> + touch_command = "touch " + newfile_path
> + os.system(touch_command)

Don't use os.system, use file_append.

> + svntest.main.run_svn(None, 'add', newfile_path)

Please try to avoid run_svn, run_and_verify_svn is better.

> + svntest.main.run_svn(None, 'propset', 'newprop', 'newvalue', newfile_path)

It would be good to run a proplist command to verify that the property
has been set successfully. Perhaps use run_and_verify_status as well.

> + svntest.main.run_svn(None, 'rm', '--force', newfile_path)
> + # recreate the file and add it again
> + os.system(touch_command)
> + svntest.main.run_svn(None, 'add', newfile_path)
> +
> + # check the properties
> + svntest.actions.run_and_verify_svn(None, [], [],
> + 'proplist', '-v', newfile_path)

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org