[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix buffer overflow from expanding long keyword values

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2005-11-02 22:38:55 CET

Ken Case <kc@omnigroup.com> writes:

> Fix buffer overflow encountered when expanding a long keyword value.
>
> * subversion/libsvn_subr/subst.c
> (translate_keyword_subst): When calculating the maximum length of
> an expanded keyword value, we need to take into account the amount of
> space used by the keyword itself or we will overflow our fixed-length
> buffer (passed in via our `buf' parameter, declared on the stack in
> svn_subst_translate_stream3() as "char keyword_buf
> [SVN_KEYWORD_MAX_LEN]").

Committed in r17149, thanks!

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Nov 2 22:39:37 2005

This is an archived mail posted to the Subversion Dev mailing list.