[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] - JavaHL bug in 1.3

From: Mark Phippard <markp_at_softlanding.com>
Date: 2005-11-01 17:10:34 CET

I was starting to add the 1.3 support into Subclipse. I ran into a bug in
the implementation we added for the new out of date Status fields. Looking
at the problem, I cannot even see why the compiler would compile this.

Anyway, without this fixed, I do not think I can do anything with the
output of the getReposLastCmtRevision() method and that is one of the main
things we needed.

Here is a patch. It fixes the problem with this method and also adds a
companion method that should have been present.

This should be backported prior to GA. However, since it only effects the
Java code, and we ship that with Subclipse it is not a huge problem for
Subclipse to just provide a patched version if necessary.

Thanks

Mark

Index: org/tigris/subversion/javahl/Status.java
===================================================================
--- org/tigris/subversion/javahl/Status.java (revision 17125)
+++ org/tigris/subversion/javahl/Status.java (working copy)
@@ -592,12 +592,22 @@
      * Revision#SVN_INVALID_REVNUM} if up to date.
      * @since 1.3
      */
- public Revision getReposLastCmtRevision()
+ public Revision.Number getReposLastCmtRevision()
     {
         return Revision.createNumber(reposLastCmtRevision);
     }
 
     /**
+ * @return the last committed revisiom as a long integer
+ * or -1 if up to date.
+ * @since 1.3
+ */
+ public long getReposLastCmtRevisionNumber()
+ {
+ return reposLastCmtRevision;
+ }
+
+ /**
      * @return The last committed date, or <code>null</code> if up to
      * date.
      * @since 1.3

_____________________________________________________________________________
Scanned for SoftLanding Systems, Inc. and SoftLanding Europe Plc by IBM Email Security Management Services powered by MessageLabs.
_____________________________________________________________________________

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Nov 1 17:11:24 2005

This is an archived mail posted to the Subversion Dev mailing list.