[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] fix broken svn_client_info

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-11-01 15:34:50 CET

Peter N. Lundblad wrote:
> I committer your original patch (with docstring fix and test case) in
> r17123. Nominating for 1.3.x.

Your log message doesn't mention the header file that you changed.

About svn_client__repos_locations(), but not directly about this change:

* The doc string doesn't indicate what the (*START_REVISION) and
(*END_REVISION) return values are for - it doesn't give any reason why they
might differ from START and END respectively.

* It also doesn't say what it does if the object didn't exist at START and/or
END in the past. (If it returns an error, it should say so, though it need not
specify which one.)

- Julian

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Nov 1 15:36:25 2005

This is an archived mail posted to the Subversion Dev mailing list.