Re: [PATCH] fix broken svn_client_info

Malcolm Rowe wrote:
> On Mon, Oct 31, 2005 at 02:33:33PM +0100, Stefan Küng wrote:
>> The function same_resource_in_head() calls svn_client__repos_locations()
>> which returns the error SVN_ERR_FS_NOT_FOUND. And as I see it, this is
>> correct if the path doesn't exist. But same_resource_in_head() is the
>> function which should not pass that error on, because it's docstring says:
>
> You're not running against a 1.0.x server, are you? Because in that case,
> we call slow_locations(), which can return either SVN_ERR_FS_NOT_FOUND
> or APR_EGENERAL if it failed to find some of the revisions.

tigris.org is running an 1.1.x server AFAIK. Not 1.0.x.

And it's not calling slow_locations(), because svn_ra_get_locations()
doesn't return SVN_ERR_RA_NOT_IMPLEMENTED but SVN_ERR_FS_NOT_FOUND.

So the question now is:
should the check for SVN_ERR_FS_NOT_FOUND be done in
svn_client__repos_locations(), or in same_resource_in_head().

After reading the docstring of svn_client__repos_locations(), I'd say
this is the function which the check should be done.

I also don't know if this happens over file:// or svn:// connections
too, or just for http://.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org