[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] fix broken svn_client_info

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2005-10-31 12:03:03 CET

Hi,

The following command fails with 1.3.x, even though it shouldn't:

svn info
http://tortoisesvn.tigris.org/svn/tortoisesvn/branches/release-0.20/src/TortoiseSVNSetup/TortoiseSVNSetup.vdproj@330
-r330

The reason is that same_resource_in_head() errors out if the URL doesn't
exist anymore in HEAD. In that case, it should just treat the HEAD as
unrelated instead.

Patch attached.

If I may make a request: since svn_client_info() is very important to
TSVN (we use it in different places, usually before some other
svn_client_* function to get additional information on how to proceed
further) I'd really love it if this could be backported to 1.3.x really
soon. If it's not possible to get it into 1.3.0 anymore, then I hope for
1.3.1.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org

[[[
Don't error out if an URL does not exist in HEAD.

* subversion/libsvn_client/info.c
  (same_resources_in_head): treat the HEAD revision as unrelated if the
  URL doesn't exist anymore in HEAD.
]]]
Index: subversion/libsvn_client/info.c
===================================================================
--- subversion/libsvn_client/info.c (Revision 17107)
+++ subversion/libsvn_client/info.c (Arbeitskopie)
@@ -289,7 +289,9 @@
                                      url, &peg_rev,
                                      &start_rev, &end_rev,
                                      ctx, pool);
- if (err && err->apr_err == SVN_ERR_CLIENT_UNRELATED_RESOURCES)
+ if (err &&
+ ((err->apr_err == SVN_ERR_CLIENT_UNRELATED_RESOURCES) ||
+ (err->apr_err == SVN_ERR_FS_NOT_FOUND)))
     {
       svn_error_clear (err);
       *same_p = FALSE;

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Oct 31 12:04:02 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.