Re: [PROPOSAL] Return of the (svnserve) log

On Sun, 2005-10-30 at 10:16 +0000, Max Bowsher wrote:
> Simply canonicalize, then strcmp the filenames to tell if they are the same
> file, and then take an advisory write lock on the files to guard against the
> server admin doing something stupid with symlinks.

In Unix systems, you can't lock against your own process, so we can't
guard against weird symlink cases that way.

At any rate, standard practice for logfiles is to open them in append
mode and write out each log message in a single write(), which is
guaranteed to be atomic. If we do that, then multiple handles to the
same file due to symlinks should be a resource-consumption issue only,
not a correctness issue.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Oct 30 16:49:42 2005