[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r17041 - in trunk/subversion: libsvn_subr

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-10-27 08:57:38 CEST

On Thu, 27 Oct 2005, Peter N. Lundblad wrote:

> On Thu, 27 Oct 2005, Philip Martin wrote:
>
> > I think svn_io_start_cmd needs to pass errfile (possibly null)
> via
> > pool userdata, and handle_child_process_error needs to retrieve it and
> > then write to it if it's not null. If errfile is null I think the
> > error message simply has to be dropped.
>
>
> This has also been suggested in some form. The problem is that one pool
> could well be used to start two commands in sequence. How do you name the
> userdata then?
>
Well, and since we use fork() (for the relevant cases), the pool is copied
before svn_io_start_cmd returns. Gah!

So, your solution seems the bestin the end. It will make the error message
available only if an errfile was passed, but that's completely reasonable.

So, now the circle is back at your first message asking why not to use the
errfile, and my answer is: that's a good idea. :-)

Thank you,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Oct 27 08:59:10 2005

This is an archived mail posted to the Subversion Dev mailing list.