[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: When to commit failing tests (was: Re: svn commit: r17032 - trunk/subversion/tests/clients/cmdline)

From: Justin Erenkrantz <justin_at_erenkrantz.com>
Date: 2005-10-26 21:12:00 CEST

--On October 26, 2005 8:24:45 PM +0200 "Peter N. Lundblad"
<peter@famlundblad.se> wrote:

> The problem with your approach is that it slows down things for everyone
> else. When I want to run tests and get a failure, I have to examine and
> dscover that it was just that other regression that still fails. If I made
> a commit, I have to examine the nightly failure mails, because I can't
> just assume that it is your test that fail. I think that's a waste of
> time.

I disagree. If we have a known regression and a test that indicates the
bug, we should check it in as soon as possible - even if we don't have a
fix at hand.

If you're annoyed by the failing test, then you can fix the bug. -- justin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Oct 26 21:13:25 2005

This is an archived mail posted to the Subversion Dev mailing list.