On Tue, 25 Oct 2005, Daniel Berlin wrote:
> On Tue, 2005-10-25 at 17:08 -0400, Greg Hudson wrote:
> > On Tue, 2005-10-25 at 16:23 -0400, Daniel Berlin wrote:
> > > > > + return svn_cmdline_handle_exit_error (err, pool, "svn: ");
> > > > > + }
> > > > > + opt_state.end_revision.value.number = strtol (opt_arg, &end, 10);
> > > > > + opt_state.end_revision.kind = svn_opt_revision_number;
> > (I see a tab here. Tabs must die!)
> > > > > + if (end == opt_arg || *end != '\0')
> > > > > + {
> > > > > + err = svn_error_create (SVN_ERR_CL_ARG_PARSING_ERROR, NULL,
> > > > > + _("Non-numeric change argument given"));
> > > >
> > > > So the argument must be a number? You haven't explicitly mentioned that.
> > >
> > > Yes, how would we know what date - 1 is?
> >
> > -c {DATE} would mean the same thing as -r X-1:X where X is what {DATE}
> > resolves to.
> >
> > Admittedly, "show me or merge in the change I made most recently as of
> > foo time" is probably an edge case, but it does have a straightforward
> > meaning in my mind.
>
> I can accept the full revision format if that's what we want. It just
> seemed weird to talk about "change 2005-06-19", when 2005-06-19 is not a
> revision number.
Yet, 2005-06-19 does map to a specific revision, and grabbing the delta
between that revision and the previous revision would certainly parallel the
behavior of passing revnums to -c. Even with the obvious parallel, is
anyone likely to actually use the date variation of this feature? Perhaps...
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Oct 26 19:12:57 2005