Marc Sherman wrote:
> Branko Čibej wrote:
>
>>>
>> For what you describe, you _definitely_ need the _is_ version of the
>> API. effetively, you want to do what libsvn_wc does; actually use
>> either _svn or .svn, but treat both as special names (e.g., even if
>> the .net hack is enabled, you still can't "svn mkdir .svn").
>>
>> Reading this discussion, I'm now really sorry I ever provided the
>> _get_ form.
>
>
> Brane, I think you've misunderstood what happens in Subclipse. The
> is_ api can only replace direct string comparisons in the Subclipse
> code. However, there are places where Subclipse must pass the admin
> dir names in to Eclipse code, that is not controlled by the plugin, so
> those places cannot be modified to call the is_ api to replace the
> string comparison.
>
>>> I do not think we ever have a case where we have some folder name
>>> and we want to check if is an admin directory or not.
>>>
>> I definitely hope client code doesn't do that...
>
>
> As Mark pointed out later in the thread, there is in fact client code
> that needs to do that, in order to suppress indexing/browsing/display
> of the folder in the project tree. And that's done by the Eclipse
> core, not by the Subclipse plugin, so a get_ api that returns all
> possible admin dir names is what's really needed.
Urgh, yuck. I do understand your point, it just seems messy to export
that knowledge.
> In the interim, for 1.3 release, it's probably acceptable for
> Subclipse to be modified to always register ".svn", and conditionally
> also register the return of the get_ api, if it's different from ".svn".
adm_opt_to_target_array(2?) does something similar.
-- Brane
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Oct 23 03:00:05 2005