On Fri, 21 Oct 2005, Justin Erenkrantz wrote:
> --On October 21, 2005 3:38:13 PM -0700 Garrett Rooney
> <rooneg@electricjellyfish.net> wrote:
>
> > mode it's totally useless. So I'd like to propose a new
> > svn_ra_get_dir2 function, which takes a new argument that indicates
> > what parts of the dirent you get back from the server. It'd look
> > something like this.
> >
> ># define SVN_DIRENT_FIELD_KIND = 0x00001;
> ># define SVN_DIRENT_FIELD_SIZE = 0x00002;
> ># define SVN_DIRENT_FIELD_HAS_PROPS = 0X00004;
> ># define SVN_DIRENT_FIELD_CREATED_REV = 0X00008;
> ># define SVN_DIRENT_FIELD_TIME = 0X00016;
> ># define SVN_DIRENT_FIELD_LAST_AUTHOR = 0X00032;
>
> Sounds like we need something similar to what apr_stat does with the
> APR_FINFO_* #defines. This proposal is in line with that, so +1. -- justin
>
If I understand correctly, the reason for APR to add these flags is
because some of the information is really expensive to fetch on some
platform and there's nothing APR can do about it.
For us it might be different. Maybe we can do something about the cause of
the problem instead of introducing API complexity.
The problem is that we get and transfer entryprops in other places as
well. For example, do_status will do this and the cmdline client will
throw it away. Should we add flags here too?
I'm not saying I object to this change if it is shown to be hard to
optimize the lower level code.
Regards,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 22 23:07:01 2005