svn_wc_external_item_dup parameter names

There's a mismatch between the prototype and the definition of
svn_wc_external_item_dup(), introduced in r16772 and ported to 1.3.x in r16791:

> Index: branches/1.3.x/subversion/include/svn_wc.h
> ===================================================================
[...]
> /**
> + * Return a duplicate of @a item, allocated in @a pool. No part of the new
> + * item will be shared with @a item.

Here: "item".

> + *
> + * @since New in 1.3.
> + */
> +svn_wc_external_item_t *
> +svn_wc_external_item_dup (const svn_wc_external_item_t *entry,

Here: "entry".

> + apr_pool_t *pool);

> Index: branches/1.3.x/subversion/libsvn_wc/util.c
> ===================================================================
[...]
> +svn_wc_external_item_t *
> +svn_wc_external_item_dup (const svn_wc_external_item_t *item, apr_pool_t *pool)

Here "item".

It's legal C but obviously not what we meant. I have no preference on which
way to resolve it.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 22 19:14:22 2005