[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: 16855 and our secret neighbors

From: Daniel Berlin <dberlin_at_dberlin.org>
Date: 2005-10-21 03:34:51 CEST

On Fri, 2005-10-21 at 00:58 +0100, Philip Martin wrote:
> Daniel Berlin <dberlin@dberlin.org> writes:
> > 16855 is the change, currently on trunk, and proposed for 1.3.x, which
> > stops outputting "END\n" to empty prop files, wasting 4 bytes (which
> > ends up wasting a disk block per file on most FSen, and multiplying out
> > for gcc, 250 meg of space per checkout)
> 16855 only helps if the files and directories have no properties, is
> gcc going to drop all properties, including svn:eol-style?

Actually, if the files have no properties. dirprops are per-dir. we
don't have 30,000 directories.

And yes, for the moment, we are going to drop all properties on files,
except svn:executable, and dirprops.

The problem isn't that we have properties. It's that *everything* had a
eol-style property, including every file in the testsuite. That's a
*lot* of properties. While we like to say subversion supports
properties, i believe this exercise has shown we aren't very space
efficient about it in working copies.

> > I also believe we should fully document the WC format in 1.4, so people
> > reimplementing it aren't hit by our little implementation niggles.
> >
> > This probably means moving away from hash_read, which has little niggles
> > in it (in fact, it's one of those niggles that allows this change to be
> > backwards compatible), to hash_read2, which is unforgiving.
> I don't object to documentation, but you appear to mean more than
> simply documenting it; I think you mean that we should guarantee that
> it won't change until we bump the wc format.

That's what we try to do now.

> I don't really like that
> idea, aside from the implementation difficulties (what happens when
> the code and the documentation don't match?) I don't see what the
> Subversion project gains by doing it.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Oct 21 03:36:49 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.