[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH]: Stop putting stuff in empty props files

From: Daniel Berlin <dberlin_at_dberlin.org>
Date: 2005-10-20 21:00:02 CEST

On Thu, 2005-10-20 at 22:56 +0400, Ivan Zhakov wrote:
> On 10/20/05, Daniel Berlin <dberlin@dberlin.org> wrote:
> > Actually, i think i can teach it to not create the props file if the
> > hash is empty, which works on all versions (they stat the path first,
> > and treat non-existence as emptyness).
> >
> > That works fine for my porpoises.
> I am going to try this tomorrow, but I consider it requires WC version
> bump and planned in wc-propcaching branch. Also I consider this could
> encourage problems in loggy code which copy/move props files.

Yes, you hit a couple log operations that don't check for existence.

If they called empty_props_p before doing things on the props, they'd
avoid this.

> --
> Ivan Zhakov

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Oct 20 21:02:00 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.